Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: make prereq titles consistent #7035

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Docs: make prereq titles consistent #7035

merged 1 commit into from
Nov 17, 2023

Conversation

chrisdoherty4
Copy link
Contributor

The titles for most requirements pages had an additional # making them inconsistent with other pages under the same sections.

@chrisdoherty4
Copy link
Contributor Author

/approve
/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@chrisdoherty4: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added area/docs Documentation documentation and removed approved labels Nov 13, 2023
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80fc4e6) 71.76% compared to head (4dcefa5) 71.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7035   +/-   ##
=======================================
  Coverage   71.76%   71.76%           
=======================================
  Files         532      532           
  Lines       41627    41627           
=======================================
  Hits        29873    29873           
  Misses      10078    10078           
  Partials     1676     1676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisdoherty4 chrisdoherty4 merged commit f520284 into aws:main Nov 17, 2023
6 of 7 checks passed
@chrisdoherty4 chrisdoherty4 deleted the docs/prereq-titles branch November 17, 2023 23:00
@eks-distro-pr-bot
Copy link
Contributor

@chrisdoherty4: new pull request created: #7059

In response to this:

/approve
/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants