Remove vSphere DHCP customization page #7058
Conversation
chrisdoherty4
requested review from
csplinter,
chrisnegus and
jacobweinstock
eks-distro-bot
added
the
size/M
|
/hold |
|
@chrisdoherty4: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
I have no particular reason to keep this page. But if you do remove it, please also deal with references to this page here: https://anywhere.eks.amazonaws.com/docs/troubleshooting/troubleshooting/#no-ip-assigned-to-a-vm and https://anywhere.eks.amazonaws.com/docs/getting-started/vsphere/vsphere-prereq/#prepare-a-vmware-vsphere-environment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7058 +/- ##
=======================================
Coverage 71.34% 71.34%
=======================================
Files 544 544
Lines 41963 41963
=======================================
Hits 29940 29940
Misses 10345 10345
Partials 1678 1678 ☔ View full report in Codecov by Sentry. |
We include an item on the vSphere pre-req that stipulates a DHCP server is required on the network. The vSphere DHCP doc goes a step further and provides configurations for custom DHCP solutions which we don't support.
eks-distro-bot
added
size/L
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisdoherty4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@chrisdoherty4: new pull request created: #7066 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We include an item on the vSphere pre-req that stipulates a DHCP server is required on the network. The vSphere DHCP doc goes a step further and provides configurations for custom DHCP solutions which we don't support.