Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for NodeUpgradeController #7061

Merged
merged 9 commits into from
Nov 23, 2023

resolve comments

b691d5e
Select commit
Loading
Failed to load commit list.
Merged

Add implementation for NodeUpgradeController #7061

resolve comments
b691d5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 23, 2023 in 0s

71.56% (+0.21%) compared to a97e239

View this Pull Request on Codecov

71.56% (+0.21%) compared to a97e239

Details

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (a97e239) 71.34% compared to head (b691d5e) 71.56%.
Report is 9 commits behind head on main.

Files Patch % Lines
controllers/nodeupgrade_controller.go 75.09% 51 Missing and 15 partials ⚠️
pkg/api/v1alpha1/nodeupgrade_types.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7061      +/-   ##
==========================================
+ Coverage   71.34%   71.56%   +0.21%     
==========================================
  Files         544      545       +1     
  Lines       41963    42318     +355     
==========================================
+ Hits        29940    30283     +343     
+ Misses      10345    10343       -2     
- Partials     1678     1692      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.