Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binary installation procedure #7125

Closed

Conversation

jaradtke-aws
Copy link
Member

Issue #, if available:
The methods demonstrating who to install eksctl, eksctl-anywhere, and kubectl were not following best-practice.

Description of changes:
I am mirroring the process called out in another page:
https://anywhere.eks.amazonaws.com/docs/getting-started/install/

Testing (if applicable):
N/A - following other examples.

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csplinter for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2023
Had to update eksctl (inadvertently had kubectl in the eksctl stanza)
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5557c8) 73.34% compared to head (46e28bb) 71.57%.
Report is 712 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7125      +/-   ##
==========================================
- Coverage   73.34%   71.57%   -1.78%     
==========================================
  Files         449      545      +96     
  Lines       37329    42350    +5021     
==========================================
+ Hits        27380    30312    +2932     
- Misses       8314    10345    +2031     
- Partials     1635     1693      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna
Copy link
Member

Closing as these changes have been merged in #7252.

@abhay-krishna
Copy link
Member

/close

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants