Add support for etcd scaling #7127
Conversation
|
Skipping CI for Draft Pull Request. |
eks-distro-bot
added
the
size/L
ahreehong
force-pushed
the
etcd-scaling
branch
3 times, most recently
from
45b80b4 to
defcfa6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7127 +/- ##
==========================================
+ Coverage 71.64% 71.65% +0.01%
==========================================
Files 556 556
Lines 43190 43185 -5
==========================================
+ Hits 30943 30944 +1
+ Misses 10537 10532 -5
+ Partials 1710 1709 -1 ☔ View full report in Codecov by Sentry. |
ahreehong
force-pushed
the
etcd-scaling
branch
5 times, most recently
from
01d18d1 to
ef841de
Compare
| framework.WithClusterFiller( | ||
| api.WithKubernetesVersion(v1alpha1.Kube127), | ||
| api.WithExternalEtcdTopology(1), | ||
| api.WithControlPlaneCount(1), |
There was a problem hiding this comment.
can we set the worker node count explicitly here as well?
| "external to local etcd configuration": { | ||
| cOld: externalEtcdCluster, | ||
| cNew: stackedEtcdCluster, | ||
| expectErr: "Forbidden: cannot switch from external to local etcd topology", |
There was a problem hiding this comment.
nit:
| expectErr: "Forbidden: cannot switch from external to local etcd topology", | |
| expectErr: "Forbidden: cannot switch from external to stacked etcd topology", |
ahreehong
force-pushed
the
etcd-scaling
branch
from
ef841de to
e8f886a
Compare
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahreehong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.