Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create management cluster using controller bootstrap task #7366

Closed
wants to merge 2 commits into from

Conversation

mitalipaygude
Copy link
Member

@mitalipaygude mitalipaygude commented Jan 25, 2024

Issue #, if available:

Description of changes:
Create management cluster using controller bootstrap task
The original #7110 is being split into smaller PRs. This PR is the first one.

Testing (if applicable):

  • The whole workflow has been tested end to end for Docker, vSphere, and Cloudstack providers.
  • Unit tests

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mitalipaygude. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (0770793) 71.79% compared to head (41ea7e0) 71.91%.
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/clustermanager/eksa_installer.go 87.50% 4 Missing and 2 partials ⚠️
pkg/dependencies/factory.go 90.32% 1 Missing and 2 partials ⚠️
pkg/workflows/management/create_bootstrap.go 90.90% 2 Missing ⚠️
pkg/workflows/management/create_install_capi.go 91.30% 2 Missing ⚠️
pkg/workflows/management/create_install_eksa.go 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7366      +/-   ##
==========================================
+ Coverage   71.79%   71.91%   +0.11%     
==========================================
  Files         563      566       +3     
  Lines       43689    43950     +261     
==========================================
+ Hits        31368    31606     +238     
- Misses      10590    10605      +15     
- Partials     1731     1739       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitalipaygude
Copy link
Member Author

/test eks-anywhere-e2e-presubmit

@mitalipaygude mitalipaygude force-pushed the retrier_refactor branch 3 times, most recently from 15a6fb1 to 39519d7 Compare January 26, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants