External etcd support for Nutanix

[adiantum]

Description of changes:
External etcd support for Nutanix

• change Nutanix provider code
• change cp-template
• add new unit tests
• change unit tests

Testing (if applicable):

$ eksctl anywhere create cluster -f ./eksa-test-ext-etcd-new-ubuntu2204-1-28.yaml --bundles-override bin/local-bundle-release.yaml
Performing setup and validations
odd number of arguments passed as key-value pairs for logging	{"ignored key": "test-ext-etcd-new"}
ValidateClusterSpec for Nutanix datacenter
Warning: Skipping TLS validation for insecure connection to Nutanix Prism Central; this is not recommended for production use
✅ Nutanix Provider setup is valid
✅ Validate OS is compatible with registry mirror configuration
✅ Validate certificate for registry mirror
✅ Validate authentication for git provider
✅ Validate cluster's eksaVersion matches EKS-A version
Creating new bootstrap cluster
Provider specific pre-capi-install-setup on bootstrap cluster
Installing cluster-api providers on bootstrap cluster
Provider specific post-setup
Creating new workload cluster
Installing networking on workload cluster
Creating EKS-A namespace
Installing cluster-api providers on workload cluster
Installing EKS-A secrets on workload cluster
Installing resources on management cluster
Moving cluster management from bootstrap to workload cluster
Installing EKS-A custom components (CRD and controller) on workload cluster
Installing EKS-D components on workload cluster
Creating EKS-A CRDs instances on workload cluster
Installing GitOps Toolkit on workload cluster
GitOps field not specified, bootstrap flux skipped
Writing cluster config file
Deleting bootstrap cluster
🎉 Cluster created!
--------------------------------------------------------------------------------------
The Amazon EKS Anywhere Curated Packages are only available to customers with the
Amazon EKS Anywhere Enterprise Subscription
--------------------------------------------------------------------------------------
Enabling curated packages on the cluster
Installing helm chart on cluster	{"chart": "eks-anywhere-packages", "version": "0.0.0-3b5440427449629eeb5c981bdd5743d37096c4c5"}

$ kubectl get nodes
NAME                                 STATUS   ROLES           AGE   VERSION
test-ext-etcd-new-fnrfk              Ready    control-plane   39m   v1.28.5-eks-dd170a8
test-ext-etcd-new-md-0-92fnm-tkp88   Ready    <none>          39m   v1.28.5-eks-dd170a8
test-ext-etcd-new-md-0-92fnm-w2kdn   Ready    <none>          40m   v1.28.5-eks-dd170a8
test-ext-etcd-new-t674l              Ready    control-plane   41m   v1.28.5-eks-dd170a8

$ kubectl get machines -n eksa-system
NAME                                 CLUSTER             NODENAME                             PROVIDERID                                       PHASE     AGE   VERSION
test-ext-etcd-new-etcd-dslgk         test-ext-etcd-new                                        nutanix://652b8422-925a-496e-9d3f-ee3fc06d4fe9   Running   38m
test-ext-etcd-new-etcd-kxxcr         test-ext-etcd-new                                        nutanix://8ece6cce-b992-4426-8548-83f935ffeb4d   Running   38m
test-ext-etcd-new-etcd-zw8bj         test-ext-etcd-new                                        nutanix://14b73305-e32f-4611-8d8f-ad19b6195f1c   Running   38m
test-ext-etcd-new-fnrfk              test-ext-etcd-new   test-ext-etcd-new-fnrfk              nutanix://901a25d6-cfee-447f-83bd-33024a8ad637   Running   38m   v1.28.4-eks-1-28-14
test-ext-etcd-new-md-0-92fnm-tkp88   test-ext-etcd-new   test-ext-etcd-new-md-0-92fnm-tkp88   nutanix://2f5dc3b7-c2ba-4100-a0aa-977d4cc7c8b1   Running   38m   v1.28.4-eks-1-28-14
test-ext-etcd-new-md-0-92fnm-w2kdn   test-ext-etcd-new   test-ext-etcd-new-md-0-92fnm-w2kdn   nutanix://63b9359f-2e7f-4366-957a-99340e4381f6   Running   38m   v1.28.4-eks-1-28-14
test-ext-etcd-new-t674l              test-ext-etcd-new   test-ext-etcd-new-t674l              nutanix://c5b857c5-466d-445c-af7e-cc6265e3772c   Running   38m   v1.28.4-eks-1-28-14

Documentation added/planned (if applicable):
External etcd configuration will be added to Nutanix provider docs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[eks-distro-bot]

Hi @adiantum. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abhinavmpandey08]

/ok-to-test

[codecov]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (c12f6c8) 73.53%.
Report is 81 commits behind head on main.

Files	Patch %	Lines
cmd/eksctl-anywhere/cmd/generateclusterconfig.go	0.00%	14 Missing ⚠️
pkg/providers/nutanix/provider.go	92.85%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7550      +/-   ##
==========================================
+ Coverage   73.48%   73.53%   +0.05%     
==========================================
  Files         579      580       +1     
  Lines       36357    36664     +307     
==========================================
+ Hits        26718    26962     +244     
- Misses       7875     7925      +50     
- Partials     1764     1777      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[abhinavmpandey08]

/approve
/lgtm

[eks-distro-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abhinavmpandey08]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavmpandey08]

/test eks-anywhere-presubmit