Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Additional notes related EKS-A vSphere Installation #7577

Closed
wants to merge 14 commits into from

Conversation

vrv7567
Copy link

@vrv7567 vrv7567 commented Feb 14, 2024

Issue #, if available:
NA

Description of changes:

  • The documentation for resource-pool name was incorrect which is required for EKS-A installation on vSphere
  • Additional important note while using eksctl v1.18.x on vSphere 7.0.2, as privileges are missing in v7.0.2
{
    "Permissions": |-
          - username: eksa@vsphere.local
            objectType: Folder
            path: /Datacenter/vm/eksa-vms
            permissions:
              - ContentLibrary.AddCertToTrustStore
              - ContentLibrary.DeleteCertFromTrustStore
              - vSphereDataProtection.Protection
              - vSphereDataProtection.Recovery
          - username: eksa@vsphere.local
            objectType: VirtualMachine
            path: /Datacenter/vm/Templates/bottlerocket-v1.25.16-kubernetes-1-25-eks-30-amd64-f19c7cc
            permissions:
              - ContentLibrary.AddCertToTrustStore
              - ContentLibrary.DeleteCertFromTrustStore
              - vSphereDataProtection.Protection
              - vSphereDataProtection.Recovery
          - username: eksa@vsphere.local  
            objectType: Folder
            path: /Datacenter/vm/Templates
            permissions:
              - ContentLibrary.AddCertToTrustStore
              - ContentLibrary.DeleteCertFromTrustStore
              - vSphereDataProtection.Protection
              - vSphereDataProtection.Recovery
}
2024-02-14T11: 14: 09.674Z        V0      ❌ Validation failed    {
    "validation": "vsphere Provider setup is valid",
    "error": "validating vsphere user privileges: user eksa@vsphere.local missing vSphere permissions",
    "remediation": ""
}

Testing (if applicable):
NA

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csplinter for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrv7567 vrv7567 changed the title [Docs] Additional notes related eksa vSphere Installation [Docs] Additional notes related EKS-A vSphere Installation Feb 14, 2024
@eks-distro-bot
Copy link
Collaborator

Hi @vrv7567. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2024
@vrv7567
Copy link
Author

vrv7567 commented Mar 8, 2024

@abhay-krishna I'd appreciate if this PR can be brought to notice to right set-of-eyes. This is a docs change that would save hours-of-googling while using EKS-A on vSphere

@vrv7567
Copy link
Author

vrv7567 commented Mar 8, 2024

@csplinter @rothgar - from docs/OWNERS

Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few corrections.

vrv7567 and others added 3 commits March 27, 2024 14:25
…d.md

Co-authored-by: Chris Negus <striker57@gmail.com>
…d.md

Co-authored-by: Chris Negus <striker57@gmail.com>
…d.md

Co-authored-by: Chris Negus <striker57@gmail.com>
1. Create cluster
{{% alert title="Important" color="warning" %}}

If your vSphere version is 7.0.2, then few user privileges don't exist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true for all vSphere versions 7.0 and above?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had licenses for vSphere 7.0.2 where I've hit into this issue :/

I do not have any concrete proof if it can be reproduced in older versions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csplinter Do you foresee any changes or the PR's good to merge? Just checking here if this can be closed

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.65%. Comparing base (fe2dad6) to head (020285f).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7577   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files         578      578           
  Lines       36610    36610           
=======================================
  Hits        26965    26965           
  Misses       7919     7919           
  Partials     1726     1726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrv7567 vrv7567 closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants