Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary validations for upgrade management components #7578

Merged

Conversation

cxbrowne1207
Copy link
Member

@cxbrowne1207 cxbrowne1207 commented Feb 14, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

  • Manual testing
  • Running E2E tests
--- PASS: TestVSphereKubernetes128UpgradeManagementComponents (747.19s)
PASS
--- PASS: TestDockerKubernetesUpgradeManagementComponents (615.07s)
PASS
--- PASS: TestCloudStackKubernetes128UpgradeManagementComponents (854.62s)
PASS

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2024
@cxbrowne1207 cxbrowne1207 changed the title remove setup upgrade cluster validations Remove setup upgrade cluster validations for upgrade management components Feb 14, 2024
@cxbrowne1207 cxbrowne1207 changed the title Remove setup upgrade cluster validations for upgrade management components Remove unnecessary validations for upgrade management components Feb 14, 2024
pkg/providers/provider.go Outdated Show resolved Hide resolved
@cxbrowne1207 cxbrowne1207 force-pushed the mc-remove-cluster-spec-validations branch 3 times, most recently from ef7e7e6 to c5343e9 Compare February 14, 2024 19:33
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (d3e47b2) 73.54%.
Report is 60 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/create_workload.go 18.18% 7 Missing and 2 partials ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
pkg/providers/vsphere/vsphere.go 0.00% 5 Missing ⚠️
pkg/clustermanager/cluster_manager.go 78.94% 4 Missing ⚠️
pkg/providers/snow/snow.go 0.00% 4 Missing ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/providers/docker/docker.go 0.00% 3 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/providers/nutanix/provider.go 77.77% 1 Missing and 1 partial ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7578      +/-   ##
==========================================
+ Coverage   73.48%   73.54%   +0.05%     
==========================================
  Files         579      580       +1     
  Lines       36357    36549     +192     
==========================================
+ Hits        26718    26879     +161     
- Misses       7875     7904      +29     
- Partials     1764     1766       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxbrowne1207 cxbrowne1207 force-pushed the mc-remove-cluster-spec-validations branch from c5343e9 to 8fc5000 Compare February 14, 2024 19:59
@cxbrowne1207 cxbrowne1207 marked this pull request as ready for review February 14, 2024 19:59
@cxbrowne1207 cxbrowne1207 force-pushed the mc-remove-cluster-spec-validations branch from 8fc5000 to 34fa75e Compare February 14, 2024 20:02
@cxbrowne1207 cxbrowne1207 force-pushed the mc-remove-cluster-spec-validations branch from 34fa75e to 9120e4e Compare February 14, 2024 20:32
@cxbrowne1207 cxbrowne1207 force-pushed the mc-remove-cluster-spec-validations branch from 9120e4e to d3e47b2 Compare February 14, 2024 21:42
Copy link
Member

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cxbrowne1207
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cxbrowne1207

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cxbrowne1207 cxbrowne1207 merged commit ab320b3 into aws:main Feb 14, 2024
10 of 13 checks passed
@cxbrowne1207 cxbrowne1207 deleted the mc-remove-cluster-spec-validations branch February 14, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants