Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for workload cluster k8s inplace upgrade #7583

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Feb 14, 2024

Issue #, if available:
#2008

Description of changes:
Added four E2E tests for multicluster workload cluster k8s upgrade in vsphere

  • 1.25 to 1.26
  • 1.26 to 1.27
  • 1.27 to 1.28
  • 1.28 to 1.29

Testing (if applicable):
Tested locally in vsphere dev env

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2024
@sp1999 sp1999 force-pushed the multicluster-e2e-inplace branch from f5e2bf0 to c7f8128 Compare February 14, 2024 23:16
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (251de48) 73.52%.
Report is 65 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/create_workload.go 35.71% 7 Missing and 2 partials ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
pkg/providers/vsphere/vsphere.go 0.00% 5 Missing ⚠️
pkg/clustermanager/cluster_manager.go 78.94% 4 Missing ⚠️
pkg/providers/snow/snow.go 0.00% 4 Missing ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/providers/docker/docker.go 0.00% 3 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/providers/nutanix/provider.go 77.77% 1 Missing and 1 partial ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7583      +/-   ##
==========================================
+ Coverage   73.48%   73.52%   +0.03%     
==========================================
  Files         579      580       +1     
  Lines       36357    36593     +236     
==========================================
+ Hits        26718    26905     +187     
- Misses       7875     7914      +39     
- Partials     1764     1774      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999 sp1999 force-pushed the multicluster-e2e-inplace branch from c7f8128 to 251de48 Compare February 14, 2024 23:51
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999 sp1999 merged commit 4d85aac into aws:main Feb 15, 2024
9 of 11 checks passed
@sp1999 sp1999 deleted the multicluster-e2e-inplace branch February 15, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants