Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template env vars for VSphere E2E tests #7586

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

abhay-krishna
Copy link
Member

This PR updates the template env vars for quick and standard VSphere E2E tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2024
@jonathanmeier5
Copy link
Member

/lgtm
/approve

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (4443161) 73.56%.
Report is 61 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/create_workload.go 35.71% 7 Missing and 2 partials ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
pkg/clustermanager/cluster_manager.go 78.94% 4 Missing ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/providers/snow/snow.go 0.00% 2 Missing ⚠️
pkg/workflows/workload/create_gitops.go 84.61% 2 Missing ⚠️
pkg/workflows/workload/post_delete.go 84.61% 2 Missing ⚠️
cmd/eksctl-anywhere/cmd/deletecluster.go 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7586      +/-   ##
==========================================
+ Coverage   73.48%   73.56%   +0.07%     
==========================================
  Files         579      580       +1     
  Lines       36357    36530     +173     
==========================================
+ Hits        26718    26872     +154     
- Misses       7875     7893      +18     
- Partials     1764     1765       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, jonathanmeier5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,jonathanmeier5]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member Author

/override eks-anywhere-e2e-presubmit

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Overrode contexts on behalf of abhay-krishna: eks-anywhere-e2e-presubmit

In response to this:

/override eks-anywhere-e2e-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit 253ac63 into aws:main Feb 14, 2024
11 checks passed
@abhay-krishna abhay-krishna deleted the template-env-vars branch March 6, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants