Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in place modular upgrade e2e tests #7588

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

vivek-koppuru
Copy link
Member

Issue #, if available:

Description of changes:
Adding e2e for modular inplace upgrades

Testing (if applicable):
--- PASS: TestVSphereKubernetes127UbuntuTo128InPlaceUpgradeWorkerOnly (705.86s)
--- PASS: TestVSphereKubernetes127UbuntuTo128InPlaceUpgradeCPOnly (937.91s)

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (8efec27) 73.51%.
Report is 65 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/create_workload.go 10.00% 7 Missing and 2 partials ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
pkg/clustermanager/cluster_manager.go 78.94% 4 Missing ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/workflows/workload/create_gitops.go 84.61% 2 Missing ⚠️
pkg/workflows/workload/post_delete.go 84.61% 2 Missing ⚠️
cmd/eksctl-anywhere/cmd/deletecluster.go 0.00% 1 Missing ⚠️
cmd/eksctl-anywhere/cmd/validations.go 0.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7588      +/-   ##
==========================================
+ Coverage   73.48%   73.51%   +0.03%     
==========================================
  Files         579      580       +1     
  Lines       36357    36593     +236     
==========================================
+ Hits        26718    26903     +185     
- Misses       7875     7915      +40     
- Partials     1764     1775      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vivek-koppuru
Copy link
Member Author

/approve

@vivek-koppuru
Copy link
Member Author

/retest

Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08, vivek-koppuru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavmpandey08,vivek-koppuru]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 8150231 into aws:main Feb 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants