use client factory to create namespace #7589
Conversation
eks-distro-bot
added
the
size/L
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7589 +/- ##
==========================================
+ Coverage 73.48% 73.67% +0.18%
==========================================
Files 579 581 +2
Lines 36357 36924 +567
==========================================
+ Hits 26718 27202 +484
- Misses 7875 7933 +58
- Partials 1764 1789 +25 ☔ View full report in Codecov by Sentry. |
tatlat
force-pushed
the
fix-creating-namespace
branch
from
5b16bc2 to
d9d7928
Compare
| ) | ||
|
|
||
| // CreateNamespaceIfNotPresent creates the namespace on the cluster if it does not already exist. | ||
| func CreateNamespaceIfNotPresent(ctx context.Context, namespace, kubeconfig string, clientFactory interfaces.ClientFactory) error { |
There was a problem hiding this comment.
Nit: can we find a different place for this?
Im ok if you move it in a separate pr
tatlat
force-pushed
the
fix-creating-namespace
branch
from
4761576 to
6352aa8
Compare
|
looks good to me! |
|
/lgtm |
|
/woof |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mitalipaygude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.