Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cluster Mover #7790

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add Cluster Mover #7790

merged 1 commit into from
Mar 22, 2024

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Mar 6, 2024

Issue #, if available:

Description of changes:
Currently for creation of management clusters, we apply EKS-Anywhere resources and waiting for conditions twice (once on bootstrap and again on workload). This causes the create command to take longer than necessary. This PR adds a way to move resources between clusters, which should shorten the time it takes to create management clusters.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.46%. Comparing base (569e325) to head (c4cf5cd).
Report is 19 commits behind head on main.

Files Patch % Lines
pkg/clustermanager/eksa_mover.go 85.45% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7790      +/-   ##
==========================================
+ Coverage   73.39%   73.46%   +0.06%     
==========================================
  Files         576      577       +1     
  Lines       35622    35735     +113     
==========================================
+ Hits        26144    26251     +107     
- Misses       7826     7827       +1     
- Partials     1652     1657       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitalipaygude
Copy link
Member

Can we read the eksa objects from the kind cluster, pause the cluster and then apply those objects to the "management" cluster?

@tatlat tatlat force-pushed the eksa-mover branch 2 times, most recently from 0a3d7c7 to 09271e6 Compare March 13, 2024 22:14
pkg/clustermanager/eksa_mover.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover_test.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover_test.go Outdated Show resolved Hide resolved
pkg/dependencies/factory.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover_test.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover_test.go Outdated Show resolved Hide resolved
pkg/clustermanager/eksa_mover_test.go Show resolved Hide resolved
@g-gaston
Copy link
Member

/lgtm

@tatlat
Copy link
Member Author

tatlat commented Mar 22, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 5f7b94d into aws:main Mar 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants