Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing replace tinkerbell action images with registry endpoint #7885

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Mar 22, 2024

Issue https://github.com/aws/eks-anywhere-internal/issues/2242

Description of changes:
When user specifies OCINamespaces with a namespace value on their registryMirrorConfiguration, we construct the containerd endpoints as <registr-endpoint>:<port>/v2/<namespace-project>/<image-path>. This is required when setting mirrors with containerd configuration. Example

  [plugins."io.containerd.grpc.v1.cri".registry.mirrors]
    [plugins."io.containerd.grpc.v1.cri".registry.mirrors."public.ecr.aws"]
      endpoint = ["https://1.2.3.4:1234/v2/eks-anywhere"]

But when replacing the tinkerbell action image uri's on the TinkerbellTemplateConfig object; we are setting them up to be pulled down using docker running on Hook OS during the tinkerbell OS provisioning stage. This fails because docker does not understand the /v2 and treats it as part of the image path.

The below fix resolves this but is temporary fix to be followed by a broader investigation around this feature.

Testing (if applicable):
Setup a proxy cache on harbor registry and tested the feature by creating a cluster.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (5f7b94d) to head (5d96b1c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7885   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files         577      577           
  Lines       35737    35740    +3     
=======================================
+ Hits        26253    26256    +3     
  Misses       7827     7827           
  Partials     1657     1657           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pokearu
Copy link
Member Author

pokearu commented Mar 22, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@pokearu: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit 12f8b6b into aws:main Mar 22, 2024
10 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@pokearu: new pull request created: #7886

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants