-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing docker e2e emissary tests for hello application #7887
Conversation
/woof |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7887 +/- ##
=======================================
Coverage 73.45% 73.46%
=======================================
Files 577 577
Lines 35740 35740
=======================================
+ Hits 26254 26256 +2
+ Misses 7828 7827 -1
+ Partials 1658 1657 -1 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.19 |
@sp1999: new pull request created: #8622 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
Emissary docker e2e tests were failing when trying to curl test deployed hello EKS Anywhere application. This worked manually and proved to be a timing issue as we were not giving enough time for the hello app to come up and start serving; hence curl vailed to hit the cluster endpoint.
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.