Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing docker e2e emissary tests for hello application #7887

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Mar 22, 2024

Description of changes:
Emissary docker e2e tests were failing when trying to curl test deployed hello EKS Anywhere application. This worked manually and proved to be a timing issue as we were not giving enough time for the hello app to come up and start serving; hence curl vailed to hit the cluster endpoint.

Testing (if applicable):

./e2e.test -test.v --test.run "TestDockerKubernetes129CuratedPackagesEmissarySimpleFlow"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
@ahreehong
Copy link
Member

/woof

@eks-distro-bot
Copy link
Collaborator

@ahreehong: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (12f8b6b) to head (a0f4191).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7887   +/-   ##
=======================================
  Coverage   73.45%   73.46%           
=======================================
  Files         577      577           
  Lines       35740    35740           
=======================================
+ Hits        26254    26256    +2     
+ Misses       7828     7827    -1     
+ Partials     1658     1657    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 6b626bb into aws:main Mar 22, 2024
9 checks passed
@sp1999
Copy link
Member

sp1999 commented Aug 16, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8622

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants