Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI generate clusterconfig description for provider flag #7888

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Mar 22, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (6b626bb) to head (6833c2a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7888   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files         577      577           
  Lines       35740    35740           
=======================================
  Hits        26256    26256           
  Misses       7827     7827           
  Partials     1657     1657           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member Author

sp1999 commented Mar 22, 2024

/retest

@sp1999 sp1999 force-pushed the update-cli-flag-description branch from bd1dd06 to b4e828b Compare March 22, 2024 22:15
@sp1999 sp1999 force-pushed the update-cli-flag-description branch from b4e828b to 6833c2a Compare March 22, 2024 22:57
@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2024
@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit a29b916 into aws:main Mar 22, 2024
10 checks passed
@sp1999 sp1999 deleted the update-cli-flag-description branch March 22, 2024 23:42
@sp1999
Copy link
Member Author

sp1999 commented Mar 22, 2024

/cherrypick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #7889

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants