Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions to update kubeconfig after manual certs renewal or cluster upgrade #7890

Merged
merged 20 commits into from
Jun 7, 2024

Conversation

saiteja313
Copy link
Contributor

Issue #, if available:

Description of changes:

  • As a EKSA Cluster admin, I want to update kubeconfig file on Admin machine post renewing cluster certificates manually.

Testing (if applicable):

  • not tested.

Documentation added/planned (if applicable): This pull request is documentation update

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Hi @saiteja313. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 23, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.38%. Comparing base (7235fc3) to head (4907a68).
Report is 14 commits behind head on main.

Current head 4907a68 differs from pull request most recent head 0cede55

Please upload reports for the commit 0cede55 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7890      +/-   ##
==========================================
- Coverage   73.42%   73.38%   -0.04%     
==========================================
  Files         577      578       +1     
  Lines       35944    35995      +51     
==========================================
+ Hits        26391    26415      +24     
- Misses       7884     7906      +22     
- Partials     1669     1674       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saiteja313
Copy link
Contributor Author

@vivek-koppuru I just addressed the comments. Feel free to re-review.

@vivek-koppuru vivek-koppuru requested a review from chrisnegus May 31, 2024 06:50
@saiteja313
Copy link
Contributor Author

@chrisnegus Addressed the gaps with new changes. Could you re-review when you get a chance please.

Co-authored-by: Chris Negus <striker57@gmail.com>
@chrisnegus
Copy link
Member

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@chrisnegus chrisnegus added the lgtm label Jun 7, 2024
@eks-distro-bot eks-distro-bot merged commit 8a82434 into aws:main Jun 7, 2024
3 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: #7890 failed to apply on top of branch "release-0.19":

Applying: added instructions to update kubeconfig
.git/rebase-apply/patch:79: trailing whitespace.
ls -ltr 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Falling back to patching base and 3-way merge...
Auto-merging docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
CONFLICT (content): Merge conflict in docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 added instructions to update kubeconfig
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants