-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added instructions to update kubeconfig after manual certs renewal or cluster upgrade #7890
Conversation
Hi @saiteja313. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7890 +/- ##
==========================================
- Coverage 73.42% 73.38% -0.04%
==========================================
Files 577 578 +1
Lines 35944 35995 +51
==========================================
+ Hits 26391 26415 +24
- Misses 7884 7906 +22
- Partials 1669 1674 +5 ☔ View full report in Codecov by Sentry. |
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
@vivek-koppuru I just addressed the comments. Feel free to re-review. |
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/support/purchase-subscription.md
Outdated
Show resolved
Hide resolved
@chrisnegus Addressed the gaps with new changes. Could you re-review when you get a chance please. |
docs/content/en/docs/clustermgmt/security/manually-renew-certs.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Negus <striker57@gmail.com>
/cherry-pick release-0.19 |
@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
@chrisnegus: #7890 failed to apply on top of branch "release-0.19":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable): This pull request is documentation update
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.