Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cluster Mover in create and delete workflows #7909

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Mar 28, 2024

Issue #, if available:

Description of changes:
Utilize cluster mover in our workflows to move EKS-Anywhere resources from and to the bootstrap cluster instead of the applier.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 28, 2024
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 73.39%. Comparing base (689f338) to head (2aef03b).
Report is 16 commits behind head on main.

❗ Current head 2aef03b differs from pull request most recent head 006453e. Consider uploading reports for the commit 006453e to get more accurate results

Files Patch % Lines
pkg/clustermanager/cluster_manager.go 71.73% 8 Missing and 5 partials ⚠️
pkg/workflows/management/delete_install_eksa.go 40.00% 6 Missing and 3 partials ⚠️
pkg/workflows/management/create_install_eksa.go 50.00% 4 Missing and 3 partials ⚠️
pkg/workflows/management/create_workload.go 20.00% 2 Missing and 2 partials ⚠️
cmd/eksctl-anywhere/cmd/createcluster.go 0.00% 3 Missing ⚠️
cmd/eksctl-anywhere/cmd/deletecluster.go 0.00% 2 Missing ⚠️
pkg/workflows/workload/createcluster.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7909      +/-   ##
==========================================
- Coverage   73.46%   73.39%   -0.08%     
==========================================
  Files         577      577              
  Lines       35744    35806      +62     
==========================================
+ Hits        26261    26281      +20     
- Misses       7826     7857      +31     
- Partials     1657     1668      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat
Copy link
Member Author

tatlat commented Apr 1, 2024

/retest

@tatlat
Copy link
Member Author

tatlat commented Apr 4, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 4328ced into aws:main Apr 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants