-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common step for downloading image-builder CLI #7926
Conversation
/cherrypick release-0.19 |
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7926 +/- ##
=======================================
Coverage 73.46% 73.47%
=======================================
Files 577 577
Lines 35745 35745
=======================================
+ Hits 26260 26262 +2
+ Misses 7827 7826 -1
+ Partials 1658 1657 -1 ☔ View full report in Codecov by Sentry. |
9521c7f
to
a020449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the commands. They work really well.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhay-krishna: new pull request created: #7930 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR extracts the
image-builder
CLI download step from every Hypervisor section and places it as a common step at the start of the node image build documentation. Also it fixes the supported Kubernetes versions list forimage-builder
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.