Add poweroff hardware cleanup step after Tinkerbell E2E tests #8140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
cxbrowne1207
changed the title
cxbrowne1207
force-pushed
the
tinkerbell-test-cleanup
branch
from
500a6aa to
84f9079
Compare
cxbrowne1207
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8140 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 577 577
Lines 35944 35944
=======================================
Hits 26391 26391
Misses 7884 7884
Partials 1669 1669 ☔ View full report in Codecov by Sentry. |
cxbrowne1207
force-pushed
the
tinkerbell-test-cleanup
branch
from
84f9079 to
3163645
Compare
cxbrowne1207
changed the title
cxbrowne1207
force-pushed
the
tinkerbell-test-cleanup
branch
from
3163645 to
85b7f79
Compare
cxbrowne1207
force-pushed
the
tinkerbell-test-cleanup
branch
from
85b7f79 to
af8985f
Compare
jacobweinstock
requested changes
May 28, 2024
cxbrowne1207
force-pushed
the
tinkerbell-test-cleanup
branch
from
af8985f to
19e9019
Compare
jacobweinstock
approved these changes
May 28, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cxbrowne1207 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR makes changes to ensure that Tinkerbell hardware for a test are powered off after a run. A few changes were made as a result:
--cleanup-vmsto--cleanup-resourcesto make it more generic (because tinkerbell does not use VMs).Provider.CleanupVMsmethod toProvider.CleanupResourcespowerOffHardwareout ofValidateHardwareDecommissionedso it does not run twice at the end of existing tests.Provider.CleanupResourcesmethod to power off hardware machines.Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.