Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Configuration for cp and wn Tinkerbell #8217

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

mitalipaygude
Copy link
Member

@mitalipaygude mitalipaygude commented May 28, 2024

Issue #, if available:

Description of changes:
This PR adds a new field KubeletConfiguration in the eksa spec for control plane and worker node configuration. This is an unstructured object that is of the kind value KubeletConfiguration. This PR adds the code for Tinkerbell provider.

Testing (if applicable):

  • unit tests
  • e2e tests

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (5940b0e) to head (c608044).
Report is 10 commits behind head on main.

Files Patch % Lines
pkg/providers/tinkerbell/template.go 88.88% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8217      +/-   ##
==========================================
+ Coverage   73.37%   73.44%   +0.06%     
==========================================
  Files         578      578              
  Lines       35995    36081      +86     
==========================================
+ Hits        26413    26498      +85     
+ Misses       7907     7905       -2     
- Partials     1675     1678       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2024
@mitalipaygude mitalipaygude force-pushed the kctink branch 3 times, most recently from 7a43d52 to f9c7b32 Compare June 6, 2024 20:08
@mitalipaygude mitalipaygude force-pushed the kctink branch 3 times, most recently from 8265636 to 887cb94 Compare June 10, 2024 06:26
@mitalipaygude
Copy link
Member Author

/test eks-anywhere-e2e-presubmit

@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2024
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/approve
/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mitalipaygude mitalipaygude merged commit 8ba7c20 into aws:main Jun 11, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants