Add Tinkerbell E2E test for Ubuntu 22.04 RTOS image #8225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8225 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 577 577
Lines 35944 35944
=======================================
Hits 26391 26391
Misses 7884 7884
Partials 1669 1669 ☔ View full report in Codecov by Sentry. |
abhay-krishna
force-pushed
the
ubuntu-rtos-e2e
branch
3 times, most recently
from
75e3c76 to
66caa2d
Compare
rahulbabu95
reviewed
May 30, 2024
test/framework/tinkerbell.go
Outdated
| tinkerbellImageUbuntu2204Kubernetes127EnvVar = "T_TINKERBELL_IMAGE_UBUNTU_2204_1_27" | ||
| tinkerbellImageUbuntu2204Kubernetes128EnvVar = "T_TINKERBELL_IMAGE_UBUNTU_2204_1_28" | ||
| tinkerbellImageUbuntu2204Kubernetes129EnvVar = "T_TINKERBELL_IMAGE_UBUNTU_2204_1_29" | ||
| tinkerbellImageUbuntu2204Kubernetes129RtosEnvVar = "T_TINKERBELL_IMAGE_UBUNTU_2204_1_29_RTOS" |
There was a problem hiding this comment.
Suggested change
| tinkerbellImageUbuntu2204Kubernetes129RtosEnvVar = "T_TINKERBELL_IMAGE_UBUNTU_2204_1_29_RTOS" | |
| tinkerbellImageUbuntu2204Kubernetes129RTOSEnvVar = "T_TINKERBELL_IMAGE_UBUNTU_2204_1_29_RTOS" |
test/framework/tinkerbell.go
Outdated
| @@ -55,6 +56,7 @@ var requiredTinkerbellEnvVars = []string{ | |||
| tinkerbellImageUbuntu2204Kubernetes127EnvVar, | |||
| tinkerbellImageUbuntu2204Kubernetes128EnvVar, | |||
| tinkerbellImageUbuntu2204Kubernetes129EnvVar, | |||
| tinkerbellImageUbuntu2204Kubernetes129RtosEnvVar, | |||
test/framework/tinkerbell.go
Outdated
Comment on lines
198
to
199
| if len(rtos) > 0 { | ||
| if rtos[0] { |
There was a problem hiding this comment.
nit: can we combine these?
Suggested change
| if len(rtos) > 0 { | |
| if rtos[0] { | |
| if len(rtos) > 0 && rtos[0] { | |
| imageEnvVar = fmt.Sprintf("%s_RTOS", imageEnvVar) | |
| } |
abhay-krishna
force-pushed
the
ubuntu-rtos-e2e
branch
from
66caa2d to
5f34092
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Tinkerbell integration tests to verify the Ubuntu 22.04 RTOS image in an end-to-end cluster creation flow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.