-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch latest E2E test AMI ID dynamically #8238
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8238 +/- ##
=======================================
Coverage 73.48% 73.48%
=======================================
Files 578 578
Lines 36489 36489
=======================================
Hits 26814 26814
Misses 7956 7956
Partials 1719 1719 ☔ View full report in Codecov by Sentry. |
6fbe75c
to
72ab342
Compare
/override lint |
@abhay-krishna: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
72ab342
to
9ba3d28
Compare
e1e2b3e
to
c27d8d3
Compare
/retest |
c27d8d3
to
25e7e9d
Compare
/retest |
25e7e9d
to
60acea5
Compare
a421940
to
7597f0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we gonna generate new amis automatically every week?
scripts/e2e_test_docker.sh
Outdated
INTEGRATION_TEST_INFRA_CONFIG="/tmp/test-infra.yml" | ||
export T_TINKERBELL_S3_INVENTORY_CSV_KEY="inventory/den80/den80-hardware.csv" | ||
|
||
INTEGRATION_TEST_AMI_ID=$(aws ec2 describe-images \ | ||
--profile ${AWS_PROFILE} \ | ||
--owners 857151390494 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't account be dynamic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we only build it in the build account and share it to these accounts, we are hardcoding the owner here.
The AMI generation will be triggered by us every week, but it will get used automatically in CI. |
e664f73
to
4518ba6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest looks good
4518ba6
to
fe8a71a
Compare
fe8a71a
to
143f1ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds the logic to dynamically fetch the latest AMI ID to use for E2E tests. We do this by calling the
DescribeImages
API with filters for the name, description and owner and then getting the latest image by creation time.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.