Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for worker node group config #8241

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Jun 3, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.40%. Comparing base (8e85e1e) to head (9279711).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8241   +/-   ##
=======================================
  Coverage   73.40%   73.40%           
=======================================
  Files         577      577           
  Lines       35921    35921           
=======================================
  Hits        26368    26368           
  Misses       7884     7884           
  Partials     1669     1669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999 sp1999 force-pushed the update-worker-node-config-docs branch from e695a72 to 9279711 Compare June 4, 2024 01:48
@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 89e57a8 into aws:main Jun 4, 2024
8 checks passed
@sp1999 sp1999 deleted the update-worker-node-config-docs branch June 4, 2024 02:56
@sp1999
Copy link
Member Author

sp1999 commented Jun 6, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8259

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member Author

sp1999 commented Jun 6, 2024

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: #8241 failed to apply on top of branch "release-0.18":

Applying: Update docs for worker node group config
Using index info to reconstruct a base tree...
M	docs/content/en/docs/getting-started/baremetal/bare-spec.md
M	docs/content/en/docs/getting-started/cloudstack/cloud-spec.md
M	docs/content/en/docs/getting-started/nutanix/nutanix-spec.md
M	docs/content/en/docs/getting-started/snow/snow-spec.md
M	docs/content/en/docs/getting-started/vsphere/vsphere-spec.md
Falling back to patching base and 3-way merge...
Auto-merging docs/content/en/docs/getting-started/vsphere/vsphere-spec.md
Auto-merging docs/content/en/docs/getting-started/snow/snow-spec.md
Auto-merging docs/content/en/docs/getting-started/nutanix/nutanix-spec.md
Auto-merging docs/content/en/docs/getting-started/cloudstack/cloud-spec.md
Auto-merging docs/content/en/docs/getting-started/baremetal/bare-spec.md
CONFLICT (content): Merge conflict in docs/content/en/docs/getting-started/baremetal/bare-spec.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update docs for worker node group config
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants