Fix NPE in vSphere etcd machine datastore usage calculation #8245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/XS
eks-distro-bot
added
size/L
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vSphere datastore usage logic for
etcdmachine configs has a bug in the specific scenario where we upgrade from a stacked etcd cluster to an unstacked etcd cluster. In this case, the previous cluster'sExternalEtcdConfigurationobject will benil, but we try to access itsCountfield without checking fornilness, which causes a panic in the validation phase. This PR adds anilcheck to the object so that we can safely dereference it, along with unit tests to cover this logic.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.