Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.19] Backport packages registry mirror certificate update changes #8256

Conversation

abhay-krishna
Copy link
Member

Backporting #7881 to release-0.19.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from abhay-krishna. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2024
* upgrade packages workflow

* Change PackageInstaller to PackageManager
@abhay-krishna abhay-krishna force-pushed the backport-packages-registry-mirror branch from be5fa84 to 50b36fe Compare June 6, 2024 00:27
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 78.16092% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-0.19@af2e5da). Learn more about missing BASE report.

Files Patch % Lines
pkg/curatedpackages/packageinstaller.go 0.00% 10 Missing ⚠️
cmd/eksctl-anywhere/cmd/createcluster.go 0.00% 3 Missing ⚠️
cmd/eksctl-anywhere/cmd/upgradecluster.go 0.00% 3 Missing ⚠️
...g/workflows/management/upgrade_curated_packages.go 81.81% 2 Missing ⚠️
pkg/dependencies/factory.go 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.19    #8256   +/-   ##
===============================================
  Coverage                ?   73.47%           
===============================================
  Files                   ?      589           
  Lines                   ?    37231           
  Branches                ?        0           
===============================================
  Hits                    ?    27354           
  Misses                  ?     8082           
  Partials                ?     1795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna abhay-krishna merged commit 5e8d6c3 into aws:release-0.19 Jun 6, 2024
9 of 11 checks passed
@sp1999 sp1999 changed the title Backport packages registry mirror certificate update changes [release-0.19] Backport packages registry mirror certificate update changes Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants