Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup duplicate code in curated packages and rename function #8258

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Jun 6, 2024

Description of changes:
This PR cleans up the same function used for different packages in e2e tests and renames it for better clarity.

Testing (if applicable):
make eks-a, make lint, make unit-test, make e2e-cross-platform

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.38%. Comparing base (5940b0e) to head (3111d62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8258   +/-   ##
=======================================
  Coverage   73.37%   73.38%           
=======================================
  Files         578      578           
  Lines       35995    35995           
=======================================
+ Hits        26413    26415    +2     
+ Misses       7907     7906    -1     
+ Partials     1675     1674    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member Author

sp1999 commented Jun 6, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rahulbabu95
Copy link
Member

/lgtm

@sp1999 sp1999 merged commit 8ab221a into aws:main Jun 6, 2024
7 of 9 checks passed
@sp1999 sp1999 deleted the cleanup-duplicate-code branch June 6, 2024 20:20
@sp1999
Copy link
Member Author

sp1999 commented Jun 12, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8305

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants