Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubelet extra args when kubelet configuration is set #8265

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

mitalipaygude
Copy link
Member

@mitalipaygude mitalipaygude commented Jun 8, 2024

Issue #, if available:

Description of changes:
This PR sets the kubelet configuration with providerID (Cloudstack) and cloud-provider (vSphere, Nutanix) setting which will be blocked for users to set. This setting is set by EKSA for kubelet extra args if Kubelet Configuration is not used.

Testing (if applicable):

  • unit test
  • E2E test

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 8, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 92.66055% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.45%. Comparing base (8ba7c20) to head (ebf7ce6).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/providers/docker/docker.go 78.37% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8265      +/-   ##
==========================================
- Coverage   73.45%   73.45%   -0.01%     
==========================================
  Files         578      578              
  Lines       36098    36162      +64     
==========================================
+ Hits        26515    26561      +46     
- Misses       7905     7914       +9     
- Partials     1678     1687       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitalipaygude mitalipaygude force-pushed the kc_def branch 4 times, most recently from 77a5d5c to 5a57ebb Compare June 10, 2024 20:19
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 10, 2024
@mitalipaygude mitalipaygude force-pushed the kc_def branch 2 times, most recently from 371961d to 8c2bbf2 Compare June 11, 2024 00:59
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/lgtm
/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mitalipaygude
Copy link
Member Author

/test eks-anywhere-presubmit

Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mitalipaygude mitalipaygude merged commit 2714ead into aws:main Jun 11, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants