BR limited settings validations for Kubelet configuration #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8268 +/- ##
==========================================
+ Coverage 73.45% 73.47% +0.02%
==========================================
Files 578 578
Lines 36098 36181 +83
==========================================
+ Hits 26515 26585 +70
- Misses 7905 7913 +8
- Partials 1678 1683 +5 ☔ View full report in Codecov by Sentry. |
mitalipaygude
force-pushed
the
br_kc
branch
2 times, most recently
from
6d201a9 to
3ff18f1
Compare
|
/test eks-anywhere-e2e-presubmit |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
BR limited settings validations for Kubelet configuration. Bottlerocket only supports a subset of settings for Kubelet Configuration. This PR validates and makes sure that only those are configured in the cluster when Bottlerocket is being used. This PR includes preflights for CLI. Another PR will be created for controller validations.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.