Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.19] Handle cluster status reconcile autoscaler #8280

Closed

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Jun 11, 2024

This is a manual cherry-pick of #8254

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 11, 2024
@sp1999
Copy link
Member Author

sp1999 commented Jun 11, 2024

/retest

@sp1999
Copy link
Member Author

sp1999 commented Jun 11, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999 sp1999 force-pushed the cherry-pick-8254-to-release-0.19 branch from 0706a51 to 50bfa70 Compare June 11, 2024 01:40
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-0.19@af23b23). Learn more about missing BASE report.

Current head 50bfa70 differs from pull request most recent head e6fcb81

Please upload reports for the commit e6fcb81 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.19    #8280   +/-   ##
===============================================
  Coverage                ?   73.48%           
===============================================
  Files                   ?      589           
  Lines                   ?    37246           
  Branches                ?        0           
===============================================
  Hits                    ?    27369           
  Misses                  ?     8082           
  Partials                ?     1795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Handle cluster status reconciliation with autoscaling configured

* Update md template to handle cluster upgrades with autoscaling configured

* Update docs for autoscaling configuration

* Add E2E tests for autoscaler upgrade flow

* Add unit tests to improve test coverage

* Add design doc for the solution
@sp1999 sp1999 force-pushed the cherry-pick-8254-to-release-0.19 branch from 50bfa70 to e6fcb81 Compare June 11, 2024 01:55
@sp1999 sp1999 closed this Jun 11, 2024
@sp1999 sp1999 deleted the cherry-pick-8254-to-release-0.19 branch June 11, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants