Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip 1.30 curated packages e2e for all providers #8282

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

rahulbabu95
Copy link
Member

Curated packages test for Kubernetes version 1.30 were skipped as we did not have the dev bundles packages images for the new Kubernetes version. Since we have added the packages bundles for 1.30, un-skipping packages tests for all providers. Additionally see that upgrade from latest minor test was skipped assuming it created 1.30 cluster from minor version. But from the code it appears it created 1.29 Kubernetes version from minor version and upgrades to 1.30 on main.

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2024
@sp1999
Copy link
Member

sp1999 commented Jun 11, 2024

/lgtm

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.45%. Comparing base (8ba7c20) to head (b230856).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8282   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         578      578           
  Lines       36098    36098           
=======================================
  Hits        26515    26515           
  Misses       7905     7905           
  Partials     1678     1678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 2d13634 into aws:main Jun 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants