Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jiayiwang7 and taneyland from OWNERS #8285

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Jun 11, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.45%. Comparing base (f2064e2) to head (0cbe68b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8285   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         578      578           
  Lines       36257    36257           
=======================================
  Hits        26632    26632           
  Misses       7933     7933           
  Partials     1692     1692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member Author

sp1999 commented Jun 11, 2024

/approve

@rahulbabu95
Copy link
Member

/lgtm

@sp1999
Copy link
Member Author

sp1999 commented Jun 12, 2024

/retest

@sp1999
Copy link
Member Author

sp1999 commented Jun 12, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999
Copy link
Member Author

sp1999 commented Jun 12, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pokearu
Copy link
Member

pokearu commented Jun 12, 2024

/lgtm
😢

@eks-distro-bot eks-distro-bot merged commit 3f38034 into aws:main Jun 12, 2024
7 checks passed
@sp1999 sp1999 deleted the update-owners branch June 12, 2024 04:55
@sp1999
Copy link
Member Author

sp1999 commented Jun 12, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8300

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request could not be created: failed to create pull request against aws/eks-anywhere#release-0.19 from head eks-distro-pr-bot:cherry-pick-8285-to-release-0.19: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for eks-distro-pr-bot:cherry-pick-8285-to-release-0.19."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants