Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding airgap support for list packages command #8286

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Jun 11, 2024

Issue https://github.com/aws/eks-anywhere-internal/issues/2270

Description of changes:
Added support for list packages in an air gapped admin env.

Testing:

./eksctl anywhere list packages --cluster airgap-cluster  --bundles-override ./release-bundle.yaml -v6

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.41%. Comparing base (fb5da43) to head (cf5eb45).
Report is 9 commits behind head on main.

Files Patch % Lines
cmd/eksctl-anywhere/cmd/listpackages.go 6.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8286      +/-   ##
==========================================
- Coverage   73.44%   73.41%   -0.04%     
==========================================
  Files         578      578              
  Lines       36101    36174      +73     
==========================================
+ Hits        26515    26557      +42     
- Misses       7908     7929      +21     
- Partials     1678     1688      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pokearu
Copy link
Member Author

pokearu commented Jun 12, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pokearu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pokearu pokearu merged commit cb8c6fa into aws:main Jun 12, 2024
9 of 12 checks passed
@sp1999
Copy link
Member

sp1999 commented Oct 18, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8864

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants