Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoscaler test workflow #8289

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix autoscaler test workflow #8289

merged 1 commit into from
Jun 11, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Jun 11, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2024
@g-gaston
Copy link
Member

/lgtm

Pls next time add a decent description to the pr to explain the change, why is necessary etc

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (2d13634) to head (a523e49).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8289   +/-   ##
=======================================
  Coverage   73.44%   73.44%           
=======================================
  Files         578      578           
  Lines       36165    36165           
=======================================
  Hits        26561    26561           
  Misses       7917     7917           
  Partials     1687     1687           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member Author

sp1999 commented Jun 11, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999 sp1999 merged commit b8cfee7 into aws:main Jun 11, 2024
7 of 9 checks passed
@sp1999 sp1999 deleted the fix-autoscaler-flow branch June 11, 2024 18:22
@sp1999
Copy link
Member Author

sp1999 commented Jun 13, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8312

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants