Use correct registries to integrate with new packages workflows #8538

abhay-krishna · 2024-07-26T18:27:10Z

Use correct registries to integrate with new packages workflows.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov · 2024-07-26T18:33:24Z

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.52%. Comparing base (5c7b2b8) to head (8b203ec).

Files	Patch %	Lines
pkg/curatedpackages/regional_registry.go	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8538   +/-   ##
=======================================
  Coverage   73.52%   73.52%           
=======================================
  Files         578      578           
  Lines       36552    36554    +2     
=======================================
+ Hits        26876    26878    +2     
  Misses       7955     7955           
  Partials     1721     1721

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/curatedpackages/regional_registry.go

mitalipaygude · 2024-07-27T07:01:38Z

Can we add unit tests for these changes? also a section in the description that describes how these changes were tested in general?

pkg/curatedpackages/reader.go

pkg/curatedpackages/regional_registry.go

eks-distro-bot · 2024-07-30T20:17:09Z

@abhay-krishna: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
eks-anywhere-docs-presubmit	`61b3006`	link	true	`/test eks-anywhere-docs-presubmit`
eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit	`61b3006`	link	true	`/test eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit`
eks-anywhere-cluster-controller-tooling-presubmit	`61b3006`	link	true	`/test eks-anywhere-cluster-controller-tooling-presubmit`
eks-anywhere-release-tooling-presubmit	`61b3006`	link	true	`/test eks-anywhere-release-tooling-presubmit`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vivek-koppuru · 2024-08-05T18:40:39Z

pkg/curatedpackages/packagecontrollerclient.go

+	}
+	if strings.Contains(pc.chart.Image(), stagingPublicRegistryAlias) {
+		registry = stagingPublicRegistryAlias
+		defaultImageRegistry = devRegionalPrivateRegistryURI


Is this not going to be the gamma account?

sp1999 · 2024-08-05T19:38:10Z

/lgtm

sp1999 · 2024-08-05T19:39:37Z

pkg/curatedpackages/regional_registry.go

-	if strings.Contains(defaultRegistry, devAccount) {
-		return devRegionalECR
+	if strings.Contains(defaultRegistry, devNonRegionalPublicRegistryAlias) {
+		return devRegionalPrivateRegistryURI


nit: add unit test to cover this line as well

pokearu

/lgtm
/approve

eks-distro-bot · 2024-08-06T00:41:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pokearu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pokearu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abhay-krishna · 2024-08-06T00:55:07Z

/cherrypick release-0.20

eks-distro-pr-bot · 2024-08-06T00:55:44Z

@abhay-krishna: new pull request created: #8571

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhay-krishna · 2024-08-06T01:00:26Z

/cherrypick release-0.19

eks-distro-pr-bot · 2024-08-06T01:01:00Z

@abhay-krishna: #8538 failed to apply on top of branch "release-0.19":

Applying: Use correct registries to integrate with new packages workflows
Using index info to reconstruct a base tree...
M	pkg/curatedpackages/regional_registry.go
M	pkg/docker/registry.go
M	pkg/docker/registry_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/docker/registry_test.go
Auto-merging pkg/docker/registry.go
Auto-merging pkg/curatedpackages/regional_registry.go
CONFLICT (content): Merge conflict in pkg/curatedpackages/regional_registry.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use correct registries to integrate with new packages workflows
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…8538)

… (#8572)

eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2024

pokearu reviewed Jul 26, 2024

View reviewed changes

pkg/curatedpackages/regional_registry.go Outdated Show resolved Hide resolved

sp1999 reviewed Jul 29, 2024

View reviewed changes

pkg/curatedpackages/reader.go Outdated Show resolved Hide resolved

sp1999 reviewed Jul 29, 2024

View reviewed changes

pkg/curatedpackages/reader.go Outdated Show resolved Hide resolved

sp1999 reviewed Jul 29, 2024

View reviewed changes

pkg/curatedpackages/regional_registry.go Outdated Show resolved Hide resolved

abhay-krishna changed the base branch from main to df/fix-clusterconfig-docs July 30, 2024 20:15

eks-distro-bot added do-not-merge/invalid-commit-message size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2024

abhay-krishna changed the base branch from df/fix-clusterconfig-docs to main July 30, 2024 23:14

eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 30, 2024

abhay-krishna force-pushed the packages-registries branch from 61b3006 to 6c82c3a Compare July 31, 2024 21:05

eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024

abhay-krishna force-pushed the packages-registries branch 2 times, most recently from d8246fd to 577815b Compare August 1, 2024 07:11

Use correct registries to integrate with new packages workflows

8b203ec

abhay-krishna force-pushed the packages-registries branch from 577815b to 8b203ec Compare August 4, 2024 21:24

vivek-koppuru reviewed Aug 5, 2024

View reviewed changes

eks-distro-bot assigned sp1999 Aug 5, 2024

eks-distro-bot added the lgtm label Aug 5, 2024

sp1999 reviewed Aug 5, 2024

View reviewed changes

pokearu approved these changes Aug 6, 2024

View reviewed changes

eks-distro-bot assigned pokearu Aug 6, 2024

eks-distro-bot added the approved label Aug 6, 2024

eks-distro-bot merged commit 4bc1f21 into aws:main Aug 6, 2024
12 checks passed

eks-distro-pr-bot mentioned this pull request Aug 6, 2024

[release-0.20] Use correct registries to integrate with new packages workflows #8571

Merged

abhay-krishna added a commit to abhay-krishna/eks-anywhere that referenced this pull request Aug 6, 2024

Use correct registries to integrate with new packages workflows (aws#…

6cc8219

…8538)

abhay-krishna mentioned this pull request Aug 6, 2024

[release-0.19] Use correct registries to integrate with new packages workflows #8572

Merged

eks-distro-bot pushed a commit that referenced this pull request Aug 6, 2024

Use correct registries to integrate with new packages workflows (#8538)…

f362fd5

… (#8572)

sp1999 mentioned this pull request Nov 5, 2024

Update artifacts bucket for packages prow jobs aws/eks-anywhere-prow-jobs#432

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use correct registries to integrate with new packages workflows #8538

Use correct registries to integrate with new packages workflows #8538

abhay-krishna commented Jul 26, 2024

codecov bot commented Jul 26, 2024 •

edited

Loading

mitalipaygude commented Jul 27, 2024

eks-distro-bot commented Jul 30, 2024 •

edited

Loading

vivek-koppuru Aug 5, 2024

sp1999 commented Aug 5, 2024

sp1999 Aug 5, 2024

pokearu left a comment

eks-distro-bot commented Aug 6, 2024

abhay-krishna commented Aug 6, 2024

eks-distro-pr-bot commented Aug 6, 2024

abhay-krishna commented Aug 6, 2024

eks-distro-pr-bot commented Aug 6, 2024

Use correct registries to integrate with new packages workflows #8538

Use correct registries to integrate with new packages workflows #8538

Conversation

abhay-krishna commented Jul 26, 2024

codecov bot commented Jul 26, 2024 • edited Loading

Codecov Report

mitalipaygude commented Jul 27, 2024

eks-distro-bot commented Jul 30, 2024 • edited Loading

vivek-koppuru Aug 5, 2024

Choose a reason for hiding this comment

sp1999 commented Aug 5, 2024

sp1999 Aug 5, 2024

Choose a reason for hiding this comment

pokearu left a comment

Choose a reason for hiding this comment

eks-distro-bot commented Aug 6, 2024

abhay-krishna commented Aug 6, 2024

eks-distro-pr-bot commented Aug 6, 2024

abhay-krishna commented Aug 6, 2024

eks-distro-pr-bot commented Aug 6, 2024

codecov bot commented Jul 26, 2024 •

edited

Loading

eks-distro-bot commented Jul 30, 2024 •

edited

Loading