Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to mark packages commands as deprecated #8861

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Oct 18, 2024

Issue #, if available:
#2270

Description of changes:
Packages commands were deprecated in #8240 from EKS-A v0.20.0 onwards. This PR updates the EKS-A docs to mark packages commands as deprecated.

Testing (if applicable):
make -C docs build

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2024
@sp1999
Copy link
Member Author

sp1999 commented Oct 18, 2024

/approve

@sp1999
Copy link
Member Author

sp1999 commented Oct 18, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (b1ebe82) to head (c9e8fc3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8861   +/-   ##
=======================================
  Coverage   72.40%   72.40%           
=======================================
  Files         578      578           
  Lines       45373    45373           
=======================================
  Hits        32853    32853           
  Misses      10790    10790           
  Partials     1730     1730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pokearu
Copy link
Member

pokearu commented Oct 18, 2024

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pokearu, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 6064328 into aws:main Oct 18, 2024
8 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8863

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants