Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics doc to add instructions for scraping etcd metrics #9089

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rajeshvenkata
Copy link
Member

Issue #, if available:
#7106

Description of changes:

  • Update the metrics doc to include instructions for scraping etcd metrics
  • Update design doc and image to include etcd

Testing (if applicable):

$ curl -H "Authorization: Bearer ${TOKEN}" "http://${NODE_IP}:2381/metrics"
# HELP etcd_cluster_version Which version is running. 1 for 'cluster_version' label with current cluster version
# TYPE etcd_cluster_version gauge
etcd_cluster_version{cluster_version="3.5"} 1
# HELP etcd_debugging_auth_revision The current revision of auth store.
# TYPE etcd_debugging_auth_revision gauge
etcd_debugging_auth_revision 1
# HELP etcd_debugging_disk_backend_commit_rebalance_duration_seconds The latency distributions of commit.rebalance called by bboltdb backend.
# TYPE etcd_debugging_disk_backend_commit_rebalance_duration_seconds histogram
etcd_debugging_disk_backend_commit_rebalance_duration_seconds_bucket{le="0.001"} 67367
etcd_debugging_disk_backend_commit_rebalance_duration_seconds_bucket{le="0.002"} 67368
etcd_debugging_disk_backend_commit_rebalance_duration_seconds_bucket{le="0.004"} 67369
etcd_debugging_disk_backend_commit_rebalance_duration_seconds_bucket{le="0.008"} 67369
etcd_debugging_disk_backend_commit_rebalance_duration_seconds_bucket{le="0.016"} 67369
etcd_debugging_disk_backend_commit_rebalance_duration_seconds_bucket{le="0.032"} 67369
etcd_debugging_disk_backend_commit_rebalance_duration_seconds_bucket{le="0.064"} 67369

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rajeshvenkata. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajeshvenkata rajeshvenkata requested a review from sp1999 December 19, 2024 00:29
@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2024
@sp1999
Copy link
Member

sp1999 commented Dec 19, 2024

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Dec 19, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Dec 19, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Saurabh Parekh <saurabhparekh99@gmail.com>
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (7e4cf0e) to head (b20d665).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9089      +/-   ##
==========================================
- Coverage   72.38%   72.38%   -0.01%     
==========================================
  Files         578      578              
  Lines       45469    45469              
==========================================
- Hits        32915    32912       -3     
- Misses      10824    10826       +2     
- Partials     1730     1731       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajeshvenkata rajeshvenkata requested a review from sp1999 December 19, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants