Skip to content

Commit

Permalink
Correct a few issues with the golang tooling (#1240)
Browse files Browse the repository at this point in the history
* point to aws repo for pr and fix bump release logic

* update the readme template
  • Loading branch information
rcrozean authored Nov 8, 2023
1 parent 23575d2 commit c6a8dff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@ func bumpRelease(gClient git.Client, r *Release) error {
logger.Error(err, "Reading file", "file", releasePath)
return err
}
// We need to check there isn't a \n character if there is we only take the first value
if len(content) > 1 {
content = content[0:1]
// Check if there is a new line character at the end of the file, if so take all but the newline
if content[len(content)-1:] == "\n" {
content = content[0 : len(content)-1]
}
cr, err := strconv.Atoi(content)
if err != nil {
Expand Down Expand Up @@ -329,7 +329,7 @@ func createReleasePR(ctx context.Context, dryrun bool, r *Release, ghUser github
SourceOwner: ghUser.User(),
SourceRepo: constants.EksdBuildToolingRepoName,
PrRepo: constants.EksdBuildToolingRepoName,
PrRepoOwner: ghUser.User(),
PrRepoOwner: constants.AwsOrgName,
}
prm := prManager.New(retrier, githubClient, prmOpts)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ Tracking Tag: `go%s`
The patches in `./patches` include relevant utility fixes for go `%s`.

### Spec
The RPM spec file in `./rpmbuild/SPECS` is sourced from the go %s SRPM available on Fedora, and modified to include the relevant patches and build the `go%s` source."
The RPM spec file in `./rpmbuild/SPECS` is sourced from the go %s SRPM available on Fedora, and modified to include the relevant patches and build the `go%s` source.

0 comments on commit c6a8dff

Please sign in to comment.