Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up dangling symlinks causing al2023 failures #1169

Merged
merged 10 commits into from
Sep 27, 2023
Merged

clean up dangling symlinks causing al2023 failures #1169

merged 10 commits into from
Sep 27, 2023

Conversation

bhavi-koduru
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bhavi-koduru. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the minimal-image Changes related to the minimal-images or tooling label Sep 20, 2023
@bhavi-koduru
Copy link
Member Author

/retest

jaxesn
jaxesn reviewed Sep 20, 2023
View reviewed changes
eks-distro-base/Dockerfile.minimal-base-git Outdated
@@ -93,7 +93,7 @@ COPY scripts/ /usr/bin
# cyrus-sasl-lib is installed for the libs, but it also includes these bins sasldblistusers2 saslpasswd2 libsasldb cyrusbdb2current
# which are not needed
# /etc/krb5.conf.d/crypto-policies is a broken symlink which is not needed
ENV CLEANUP_UNNECESSARY_FILES="/usr/sbin/sasldblistusers2 /usr/sbin/saslpasswd2 /usr/lib64/sasl2/libsasldb* /usr/bin/cyrusbdb2current /usr/lib64/libkrad* /etc/krb5.conf.d/crypto-policies /usr/lib64/libsystemd.so.*"
ENV CLEANUP_UNNECESSARY_FILES="/usr/sbin/sasldblistusers2 /usr/sbin/saslpasswd2 /usr/lib64/sasl2/libsasldb* /usr/bin/cyrusbdb2current /usr/lib64/libkrad* /etc/krb5.conf.d/crypto-policies /usr/lib64/libsystemd.so.* /etc/crypto-policies/back-ends"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be /etc/pki/tls/fips_local.cnf instead since its the bad symlink.

@bhavi-koduru bhavi-koduru force-pushed the remove-crypto-policies-symlinks branch 4 times, most recently from 19dbe59 to bbf1aba Compare September 20, 2023 19:24
@bhavi-koduru bhavi-koduru force-pushed the remove-crypto-policies-symlinks branch 2 times, most recently from ab14b19 to b53b920 Compare September 20, 2023 20:33
@bhavi-koduru
Copy link
Member Author

/retest eks-distro-base-tooling-presubmits-python-3-9-al-2023

@eks-distro-bot
Copy link
Collaborator

@bhavi-koduru: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test alertmanager-tooling-presubmit
  • /test amazon-eks-pod-identity-webhook-tooling-presubmit
  • /test athens-tooling-presubmit
  • /test aws-for-fluent-bit-helm-chart-tooling-presubmit
  • /test builder-base-tooling-presubmit-al-2
  • /test builder-base-tooling-presubmit-al-2023
  • /test eks-distro-base-test-presubmit
  • /test eks-distro-base-tooling-presubmits-compiler-base-al-2
  • /test eks-distro-base-tooling-presubmits-compiler-base-al-2023
  • /test eks-distro-base-tooling-presubmits-csi-al-2
  • /test eks-distro-base-tooling-presubmits-csi-al-2023
  • /test eks-distro-base-tooling-presubmits-csi-ebs-al-2
  • /test eks-distro-base-tooling-presubmits-csi-ebs-al-2023
  • /test eks-distro-base-tooling-presubmits-docker-client-al-2
  • /test eks-distro-base-tooling-presubmits-docker-client-al-2023
  • /test eks-distro-base-tooling-presubmits-git-al-2
  • /test eks-distro-base-tooling-presubmits-git-al-2023
  • /test eks-distro-base-tooling-presubmits-golang-1-19-al-2
  • /test eks-distro-base-tooling-presubmits-golang-1-19-al-2023
  • /test eks-distro-base-tooling-presubmits-golang-1-20-al-2
  • /test eks-distro-base-tooling-presubmits-golang-1-20-al-2023
  • /test eks-distro-base-tooling-presubmits-golang-1-21-al-2
  • /test eks-distro-base-tooling-presubmits-golang-1-21-al-2023
  • /test eks-distro-base-tooling-presubmits-haproxy-al-2
  • /test eks-distro-base-tooling-presubmits-haproxy-al-2023
  • /test eks-distro-base-tooling-presubmits-iptables-al-2
  • /test eks-distro-base-tooling-presubmits-iptables-al-2023
  • /test eks-distro-base-tooling-presubmits-java-al-2
  • /test eks-distro-base-tooling-presubmits-java-al-2023
  • /test eks-distro-base-tooling-presubmits-kind-al-2
  • /test eks-distro-base-tooling-presubmits-kind-al-2023
  • /test eks-distro-base-tooling-presubmits-nginx-al-2
  • /test eks-distro-base-tooling-presubmits-nginx-al-2023
  • /test eks-distro-base-tooling-presubmits-nodejs-16-al-2
  • /test eks-distro-base-tooling-presubmits-nodejs-16-al-2023
  • /test eks-distro-base-tooling-presubmits-nsenter-al-2
  • /test eks-distro-base-tooling-presubmits-nsenter-al-2023
  • /test eks-distro-base-tooling-presubmits-python-3-7-al-2
  • /test eks-distro-base-tooling-presubmits-python-3-7-al-2023
  • /test eks-distro-base-tooling-presubmits-python-3-9-al-2
  • /test eks-distro-base-tooling-presubmits-python-3-9-al-2023
  • /test eks-distro-base-tooling-presubmits-windows
  • /test eks-distro-release-tooling-presubmit
  • /test github-exporter-tooling-presubmit
  • /test golang-1-19-tooling-presubmit
  • /test golang-1-20-tooling-presubmit
  • /test golang-1-21-tooling-presubmit
  • /test grafana-helm-chart-tooling-presubmit
  • /test helm-chart-tooling-presubmit
  • /test kops-tooling-presubmit
  • /test prometheus-helm-chart-tooling-presubmit
  • /test prometheus-tooling-presubmit
  • /test prow-deck-tooling-presubmit
  • /test prow-plugin-tooling-presubmit

Use /test all to run the following jobs that were automatically triggered:

  • eks-distro-base-test-presubmit
  • eks-distro-base-tooling-presubmits-compiler-base-al-2
  • eks-distro-base-tooling-presubmits-compiler-base-al-2023
  • eks-distro-base-tooling-presubmits-csi-al-2
  • eks-distro-base-tooling-presubmits-csi-al-2023
  • eks-distro-base-tooling-presubmits-csi-ebs-al-2
  • eks-distro-base-tooling-presubmits-csi-ebs-al-2023
  • eks-distro-base-tooling-presubmits-docker-client-al-2
  • eks-distro-base-tooling-presubmits-docker-client-al-2023
  • eks-distro-base-tooling-presubmits-git-al-2
  • eks-distro-base-tooling-presubmits-git-al-2023
  • eks-distro-base-tooling-presubmits-golang-1-19-al-2
  • eks-distro-base-tooling-presubmits-golang-1-19-al-2023
  • eks-distro-base-tooling-presubmits-golang-1-20-al-2
  • eks-distro-base-tooling-presubmits-golang-1-20-al-2023
  • eks-distro-base-tooling-presubmits-golang-1-21-al-2
  • eks-distro-base-tooling-presubmits-golang-1-21-al-2023
  • eks-distro-base-tooling-presubmits-haproxy-al-2
  • eks-distro-base-tooling-presubmits-haproxy-al-2023
  • eks-distro-base-tooling-presubmits-iptables-al-2
  • eks-distro-base-tooling-presubmits-iptables-al-2023
  • eks-distro-base-tooling-presubmits-java-al-2
  • eks-distro-base-tooling-presubmits-java-al-2023
  • eks-distro-base-tooling-presubmits-kind-al-2
  • eks-distro-base-tooling-presubmits-kind-al-2023
  • eks-distro-base-tooling-presubmits-nginx-al-2
  • eks-distro-base-tooling-presubmits-nginx-al-2023
  • eks-distro-base-tooling-presubmits-nodejs-16-al-2
  • eks-distro-base-tooling-presubmits-nodejs-16-al-2023
  • eks-distro-base-tooling-presubmits-nsenter-al-2
  • eks-distro-base-tooling-presubmits-nsenter-al-2023
  • eks-distro-base-tooling-presubmits-python-3-7-al-2
  • eks-distro-base-tooling-presubmits-python-3-7-al-2023
  • eks-distro-base-tooling-presubmits-python-3-9-al-2
  • eks-distro-base-tooling-presubmits-python-3-9-al-2023
  • eks-distro-base-tooling-presubmits-windows

In response to this:

/retest eks-distro-base-tooling-presubmits-python-3-9-al-2023

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bhavi-koduru
Copy link
Member Author

/test eks-distro-base-tooling-presubmits-python-3-9-al-2023

@bhavi-koduru bhavi-koduru force-pushed the remove-crypto-policies-symlinks branch from b53b920 to d2299e2 Compare September 20, 2023 21:53
@bhavi-koduru bhavi-koduru changed the title clean up /etc/crypto-policies/back-ends/ files clean up dangling symlinks causing al2023 failures Sep 20, 2023
@bhavi-koduru bhavi-koduru force-pushed the remove-crypto-policies-symlinks branch 3 times, most recently from f557914 to 625ca58 Compare September 21, 2023 18:30
@bhavi-koduru bhavi-koduru force-pushed the remove-crypto-policies-symlinks branch from 625ca58 to abeedaf Compare September 21, 2023 19:58
@github-actions github-actions bot removed the minimal-image Changes related to the minimal-images or tooling label Sep 21, 2023
@bhavi-koduru
Copy link
Member Author

/retest

@bhavi-koduru bhavi-koduru force-pushed the remove-crypto-policies-symlinks branch from abeedaf to 6849457 Compare September 21, 2023 20:00
@github-actions github-actions bot added the minimal-image Changes related to the minimal-images or tooling label Sep 21, 2023
@eks-distro-bot
Copy link
Collaborator

@bhavi-koduru: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-distro-base-tooling-presubmits-python-3-9-al-2023 9077ede link true /test eks-distro-base-tooling-presubmits-python-3-9-al-2023
eks-distro-base-tooling-presubmits-golang-1-19-al-2023 38e3d4d link true /test eks-distro-base-tooling-presubmits-golang-1-19-al-2023
eks-distro-base-tooling-presubmits-golang-1-21-al-2023 38e3d4d link true /test eks-distro-base-tooling-presubmits-golang-1-21-al-2023
eks-distro-base-tooling-presubmits-golang-1-20-al-2023 38e3d4d link true /test eks-distro-base-tooling-presubmits-golang-1-20-al-2023

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bhavi-koduru bhavi-koduru merged commit 15fc08b into aws:main Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxesn jaxesn jaxesn approved these changes

Assignees

@jaxesn jaxesn

Labels
lgtm minimal-image Changes related to the minimal-images or tooling size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhavi-koduru @eks-distro-bot @jaxesn