Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.20 to build Skopeo, Hold Until EKS-D Release #1178

Closed
wants to merge 2 commits into from

Conversation

zafs23
Copy link
Contributor

@zafs23 zafs23 commented Sep 27, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zafs23. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zafs23
Copy link
Contributor Author

zafs23 commented Sep 27, 2023

/hold

@zafs23 zafs23 changed the title Bump Go version to 1.20 to build Skopeo Bump Go version to 1.20 to build Skopeo, Hold Until EKS-D Release Sep 27, 2023
@abhay-krishna
Copy link
Member

/retest

@eks-distro-bot
Copy link
Collaborator

@zafs23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
builder-base-tooling-presubmit-al-2 b498d71 link true /test builder-base-tooling-presubmit-al-2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhay-krishna
Copy link
Member

abhay-krishna commented Oct 27, 2023

We can't build newer versions of Skopeo on AL2, refer to containers/skopeo#1754 for the reason.
Closing this PR in favor of #1222.
/close

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Closed this PR.

In response to this:

Closing this PR in favor of #1222.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants