-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Mantine modal with Radix dialog #699
Draft
kmcginnes
wants to merge
11
commits into
aws:main
Choose a base branch
from
kmcginnes:radix-dialog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug found where the select menu items can not be selected. It might be possible that I need to convert them to use the new select component because of the use of React Portals in the new Dialog component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This continues the path toward the removal of Mantine and adoption of Radix. This PR replaces all usages of the Mantine component
Modal
with the Radix equivalentDialog
andAlertDialog
.The method of controlling the open and closed states of the Radix dialog's is a bit different than Mantine
Modal
and required some finessing. I've done extensive testing on the 8 different modals in the system.There are also some new style changes I've added. The dialog header now has a consistent style across all dialogs, and some now show a new subtitle. The dialog footer now has a very faint gray background to make it visually distinct from the other elements in the dialog.
For the customize style dialogs I updated the style for the section headings and improved the padding. For the alerts used during the configuration data restore process I had to redesign them a bit to fit with the standard dialog header and footer.
There are before and after shots in the validation section below.
Validation
Dialog
but notAlertDialog
Connection UI & Custom SPARQL Namespace
Not much different here. Just the new standard header and footer styles.
Configuration Restore
This required the most redesign of all.
Dialog
for the first dialog since it can be canceled and escaped easilyAlertDialog
for the success and error screens since they are informational and only have a single option for the user to chooseCustomize vertex or edge styles
Related Issues
Check List
license.
pnpm checks
to ensure code compiles and meets standards.pnpm test
to check if all tests are passing.Changelog.md
.