Fix typescript build lib target (#715)

* chore(dep): run npm audit fix. * fix(tsc): error in type definition. * chore(dep): rollback npm audit breaking webpack.
aws · Nov 9, 2024 · de7b926 · de7b926
1 parent 01964d3
commit de7b926
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/graph_notebook/widgets/package.json b/src/graph_notebook/widgets/package.json
@@ -53,7 +53,7 @@
     "source-map-loader": "0.2.4",
     "style-loader": "1.2.1",
     "ts-loader": "5.4.5",
-    "typescript": "4.1.6",
+    "typescript": "5.6.3",
     "webpack": "4.43.0",
     "webpack-cli": "3.3.11",
     "webpack-dev-server": "3.11.0"

diff --git a/src/graph_notebook/widgets/src/types.ts b/src/graph_notebook/widgets/src/types.ts
@@ -34,7 +34,7 @@ export class VisNode implements Node, DynamicObject {
 
   [key: string]: any;
 
-  constructor(readonly id: string) {
+  constructor(id: string) {
     this.id = id;
   }
 
@@ -88,9 +88,9 @@ export class VisEdge implements Edge {
   [key: string]: any;
 
   constructor(
-    readonly from: string,
-    readonly to: string,
-    readonly id: string,
+    from: string,
+    to: string,
+    id: string,
     label: string
   ) {
     this.from = from;
@@ -184,7 +184,7 @@ export class IdentifiableDynamicObject extends DynamicObject {
 
   [key: string]: any;
 
-  constructor(readonly id: string) {
+  constructor(id: string) {
     super();
     this.id = id;
   }