-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecation warnings for RL #4578
base: master
Are you sure you want to change the base?
Conversation
src/sagemaker/image_uris.py
Outdated
deprecation_warn( | ||
"SageMaker-hosted RL images no longer accept new pull requests and", | ||
"April 2024", | ||
" Please pass in `image_uri` to use RLEstimator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tech writer do not like using Please do x
in customer messaging, could you ping @judyheflin for review before merging?
@jinyoung-lim Can you please resolve the code-style issues? |
e136eba
to
5369f6b
Compare
@jinyoung-lim Could you pls fix the codestyle? https://github.com/aws/sagemaker-python-sdk/actions/runs/8724972624/job/23936838151?pr=4578 |
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.