Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly access enum member values to avoid Python version rel… #4798

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

malav-shastri
Copy link
Collaborator

@malav-shastri malav-shastri commented Jul 24, 2024

Issue #, if available:

Description of changes:

  • In python version Python 3.6 and earlier, the default str method for enum members returns the full string representation, including the class name and member name (e.g., 'HubContentType.MODEL'). Which results in an invalid public model arn format and fails to create a hub model reference for those Python versions.
  • To maintain consistency across various Python versions, explicitly accessing the value attribute of the enum object to get the value and construct the correct Hub Model Arn.

Testing done:

  • Notebook testing

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@sage-maker sage-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sage-maker sage-maker merged commit d02d524 into aws:master Jul 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants