Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IAM role policy configuration to use StringEquals for Mountpoint for Amazon S3 CSI driver #812

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Update IAM role policy configuration to use StringEquals for Mountpoint for Amazon S3 CSI driver #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions latest/ug/storage/s3-csi.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,9 @@
+
[source,json,subs="verbatim,attributes,quotes"]
----
"oidc.eks.region-code.amazonaws.com/id/EXAMPLED539D4633E53DE1B71EXAMPLE:sub": "system:serviceaccount:kube-system:s3-csi-*"
"oidc.eks.region-code.amazonaws.com/id/EXAMPLED539D4633E53DE1B71EXAMPLE:sub": "system:serviceaccount:kube-system:s3-csi-driver-sa"

Check warning on line 188 in latest/ug/storage/s3-csi.adoc

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[RedHat.PassiveVoice] 'is set' is passive voice. In general, use active voice. Consult the style guide for acceptable use of passive voice.

Raw Output:
{"message": "[RedHat.PassiveVoice] 'is set' is passive voice. In general, use active voice. Consult the style guide for acceptable use of passive voice.", "location": {"path": "latest/ug/storage/s3-csi.adoc", "range": {"start": {"line": 188, "column": 21}}}, "severity": "INFO"}
----
. Change the `Condition` operator from `"StringEquals"` to `"StringLike"`.
. Ensure that the `Condition` operator is set to `"StringEquals"`.

Check warning on line 190 in latest/ug/storage/s3-csi.adoc

View workflow job for this annotation

GitHub Actions / style-job 

[vale] reported by reviewdog 🐶
[RedHat.Definitions] Define acronyms and abbreviations (such as 'OIDC') on first occurrence if they're likely to be unfamiliar.

Raw Output:
{"message": "[RedHat.Definitions] Define acronyms and abbreviations (such as 'OIDC') on first occurrence if they're likely to be unfamiliar.", "location": {"path": "latest/ug/storage/s3-csi.adoc", "range": {"start": {"line": 190, "column": 4}}}, "severity": "INFO"}
. Choose *Update policy* to finish.

=== {aws} CLI [[awscli_s3_store_app_data]]
Expand Down Expand Up @@ -220,8 +220,8 @@
},
"Action": "sts:AssumeRoleWithWebIdentity",
"Condition": {
"StringLike": {
"oidc.eks.region-code.amazonaws.com/id/EXAMPLED539D4633E53DE1B71EXAMPLE:sub": "system:serviceaccount:kube-system:s3-csi-*",
"StringEquals": {
"oidc.eks.region-code.amazonaws.com/id/EXAMPLED539D4633E53DE1B71EXAMPLE:sub": "system:serviceaccount:kube-system:s3-csi-driver-sa",
"oidc.eks.region-code.amazonaws.com/id/EXAMPLED539D4633E53DE1B71EXAMPLE:aud": "sts.amazonaws.com"
}
}
Expand Down
Loading