Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mlflow-ai-gw-image module and update mlflow to 2.17.0 #255

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Oct 22, 2024

Describe your changes

Add mlflow-ai-gw-image module that builds mlflow Docker image and pushes to ECR.
The image hosts a MLFlow AI Gateway server.

Next steps:
We need to decide how we want to use the Docker image. We could put it in a Lambda+API Gateway to really have an AI API Gateway. Or we could link it to the rest of the modules of mlflow and deploy it as an ECS task

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests ---> just CodeBuild, no actual cdk app
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

-[X] I pulled the image from ECR and then built the server locally

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: c87c905
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@dlpzx dlpzx changed the title feat: Add mlflow-ai-gw-image module feat: Add mlflow-ai-gw-image module and update mlflow to 2.17.0 Oct 22, 2024

## Description

This module creates an mlflow tracking server container image and pushes to the specified Elastic Container Repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: copy-paste

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved now

kukushking
kukushking previously approved these changes Oct 24, 2024
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: f6181b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: eddfd92
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@dlpzx dlpzx marked this pull request as ready for review October 29, 2024 14:42
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: a2901df
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go - thanks!

@kukushking kukushking merged commit 94a5126 into awslabs:main Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants