-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mlflow-ai-gw-image
module and update mlflow to 2.17.0
#255
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mlflow-ai-gw-image
modulemlflow-ai-gw-image
module and update mlflow to 2.17.0
|
||
## Description | ||
|
||
This module creates an mlflow tracking server container image and pushes to the specified Elastic Container Repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: copy-paste
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
c87c905
to
f6181b2
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
# Conflicts: # CHANGELOG.md
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go - thanks!
Describe your changes
Add
mlflow-ai-gw-image
module that builds mlflow Docker image and pushes to ECR.The image hosts a MLFlow AI Gateway server.
Next steps:
We need to decide how we want to use the Docker image. We could put it in a Lambda+API Gateway to really have an AI API Gateway. Or we could link it to the rest of the modules of mlflow and deploy it as an ECS task
Checklist before requesting a review
CHANGELOG.MD
with a description of my changesscripts/validate.sh
)seedfarmer apply
-[X] I pulled the image from ECR and then built the server locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.