Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for dbref #1035

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Chainbreaker1
Copy link

Issue #, if available:

Description of changes:
The documentdb adapter does not support the mongodb type "dbref". For more information on "dbref" see: https://www.mongodb.com/docs/manual/reference/database-references/
I had to replace the "$" prefixes with a different prefix to make it more compatible with the athena query syntax, so i replaced it with an underscore.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@henrymai henrymai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check with the rest of the team to see if this is a change we want to take in, but I just left a minor comment for something I noticed at a glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants