Skip to content

Commit

Permalink
Fix get-jobs test check
Browse files Browse the repository at this point in the history
This commit makes the end-to-end tests for get-jobs actually check the
result of the test, and fixes a test that was failing silently.
  • Loading branch information
karkhaz committed Apr 6, 2022
1 parent cad81c0 commit f0c2187
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion test/e2e/run
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ def get_jobs(litani, run_dir, mod):
cmd.extend(configure_args(*args.get("args", []), **args.get("kwargs", {})))
jobs = subprocess.check_output(cmd)

mod.check_get_jobs(jobs)
if not mod.check_get_jobs(jobs):
sys.exit(1)

for job in mod.get_post_check_jobs():
run_litani(
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/tests/get_jobs_single_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

EXPECTED_JOB = {
"command": "echo foo",
"ci-stage": "build",
"ci_stage": "build",
"pipeline": "foo",
}

Expand Down

0 comments on commit f0c2187

Please sign in to comment.