Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate S3 gatekeeper fixes #173

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

iamahgoub
Copy link
Contributor

What does this PR do?

  • Adding missing syncset
  • Appending account id to bucket name to make it unique
  • Adding provider details

Motivation

Part of the IDP workshop.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • [] Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@candonov candonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@candonov candonov merged commit 70d1aff into awslabs:main Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants